Skip to content

[Backend Tester] Skip in-place activation tests due to lack of support in ET #13989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Backend Tester] Skip in-place activation tests due to lack of support in ET #13989

wants to merge 5 commits into from
+24 −0

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Sep 5, 2025 •
edited
Loading

These tests are failing for all backends due to lack of defunctionalization support for in-place activations. This PR disables them to reduce noise. They can be re-enabled in the future when supported. Tracking in #11700.

GregoryComer and others added 2 commits September 4, 2025 17:30
@GregoryComer
Update
bc7349b 
[ghstack-poisoned]
@GregoryComer
Update
223d5d6 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Sep 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13989

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Cancelled Jobs, 3 Pending, 1 Unrelated Failure

As of commit a6181ef with merge base 6d8583d (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Sep 5, 2025
@GregoryComer
[Backend Tester] Skip in-place activation tests due to lack of suppor…
bede30b 
…t in ET

ghstack-source-id: 154fa15
ghstack-comment-id: 3257141684
Pull-Request: #13989
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@GregoryComer GregoryComer mentioned this pull request Sep 5, 2025
Merged
This was referenced Sep 5, 2025
Open
Open
Open
Base automatically changed from gh/GregoryComer/153/head to main September 5, 2025 19:52
@GregoryComer GregoryComer mentioned this pull request Sep 5, 2025
Open
11 tasks
@GregoryComer
Update
bdad6bb 
[ghstack-poisoned]
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Sep 5, 2025
This was referenced Sep 10, 2025
Open
Open
Open
Open
GregoryComer and others added 2 commits September 10, 2025 23:22
@GregoryComer
Update
f4e54ae 
[ghstack-poisoned]
@GregoryComer
Update
a6181ef 
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GregoryComer